[improve][admin] Allow creating builtin functions in pulsar-admin CLI #15671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eolivelli
requested changes
May 19, 2022
pulsar-client-tools-test/src/test/java/org/apache/pulsar/admin/cli/CmdFunctionsTest.java
Show resolved
Hide resolved
cbornet
force-pushed
the
builtin-functions-cli
branch
from
81052b0 to
a9597a9
Compare
eolivelli
approved these changes
May 20, 2022
nicoloboschi
approved these changes
May 20, 2022
|
/pulsarbot rerun-failure-checks |
cbornet
changed the title
cbornet
changed the title
Merged
5 tasks
cbornet
force-pushed
the
builtin-functions-cli
branch
from
a9597a9 to
f86f277
Compare
cbornet
added a commit
to cbornet/pulsar
that referenced
this pull request
Jun 17, 2022
nicoloboschi
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jun 17, 2022
* Parse function userConfig to Map<String, Object> (apache#15669) Currently only {userConfig: {some-key: some-value}} is allowed which is limiting With this change any JSON compatible object is allowed. Eg: {userConfig: {some-key: [value1, value2]}} * Allow creating builtin functions in pulsar-admin CLI (apache#15671) * [fix][admin] Fix check on create function class name (apache#15700) The check was done for PYTHON or JAVA runtime but the runtime is not inferred in the admin CLI. The fix is to do the check if a jar or py is provided instead * [improve][function] Get function class name from the NAR when using built-in functions (apache#15693) * Get function class name from the NAR manifest when using built-in functions * Exclude pulsar-io.yaml from examples JAR * Build a NAR separately from the JAR for the function examples * Improve admin cli tes for built-in functions
cbornet
added a commit
to datastax/pulsar
that referenced
this pull request
Jun 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently creating a built-in function with argument
--jar builtin://my-built-in-functionis rejected with errorThe specified jar file does not exist.This change allows to do it.
Modifications
Check if the jar starts with
builtin://Verifying this change
This change added tests and can be verified as follows:
Run test
CmdFunctionsTest::testCreateFunctionWithBuiltinNarDoes this pull request potentially affect one of the following parts:
No
If
yeswas chosen, please highlight the changesDocumentation
Check the box below or label this PR directly.
Need to update docs?
doc-required(Your PR needs to update docs and you will update later)
no-need-doctrivial (or would need a full doc on builtin functions which is inexistant atm)
doc(Your PR contains doc changes)
doc-added(Docs have been already added)